Closed PinkShnack closed 1 year ago
Patch coverage: 92.59%
and project coverage change: -13.54%
:warning:
Comparison is base (
4996e23
) 91.27% compared to head (e15ccdd
) 77.74%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
FYI seems like GitHub is able to merge this without any rebasing on your end.
The tests now fail only because the regexp is not fully matching after the changes we made today.
The tests now fail only because the regexp is not fully matching after the changes we made today.
Fixed in https://github.com/DC-analysis/dclab/pull/227/commits/7f16bd054e02fb90ae8b2279eade46d8e68c6f58
FYI seems like GitHub is able to merge this without any rebasing on your end.
Even after I would update the changelog...? :D
So now I am waiting on two things:
FYI I built ShapeOut2 with this branch of dclab and I can open the features. Everything seems to work as normal.
Sorry, I cannot review the current state, because GitHub is asking me to review all of the commits I made since the tree diverged for this PR.
Sorry, I cannot review the current state, because GitHub is asking me to review all of the commits I made since the tree diverged for this PR.
Yeah this is annoying. I dont think I merged or rebased, so why are your changes included? It is a pity we can't compare this branch with the current main...
Also, I haven't changed the changelog...
This is how to fix this "bug" which is "by design" by GitHub: https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch
(highest voted answer says: click edit, change the base branch, then change it back).
FYI the docs build for me locally.
As described in bullet point 1 here, the QPI features must be added to the feature definitions.
To-do
dclab/definitions
.qpi_focus
and related metadata ("focus metric", "focus minimizer" and "focus kernel")