DC-analysis / dclab

Python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets
https://dclab.readthedocs.io
Other
10 stars 12 forks source link

Add QPI features to dclab definitions #227

Closed PinkShnack closed 1 year ago

PinkShnack commented 1 year ago

As described in bullet point 1 here, the QPI features must be added to the feature definitions.

To-do

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 92.59% and project coverage change: -13.54% :warning:

Comparison is base (4996e23) 91.27% compared to head (e15ccdd) 77.74%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #227 +/- ## =========================================== - Coverage 91.27% 77.74% -13.54% =========================================== Files 104 104 Lines 7344 7368 +24 =========================================== - Hits 6703 5728 -975 - Misses 641 1640 +999 ``` | [Files Changed](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis) | Coverage Δ | | |---|---|---| | [dclab/definitions/feat\_const.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvZGVmaW5pdGlvbnMvZmVhdF9jb25zdC5weQ==) | `100.00% <ø> (ø)` | | | [dclab/rtdc\_dataset/config.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvcnRkY19kYXRhc2V0L2NvbmZpZy5weQ==) | `74.06% <ø> (-11.66%)` | :arrow_down: | | [dclab/rtdc\_dataset/writer.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvcnRkY19kYXRhc2V0L3dyaXRlci5weQ==) | `93.33% <83.33%> (-0.88%)` | :arrow_down: | | [dclab/definitions/meta\_const.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvZGVmaW5pdGlvbnMvbWV0YV9jb25zdC5weQ==) | `100.00% <100.00%> (ø)` | | | [dclab/definitions/meta\_parse.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvZGVmaW5pdGlvbnMvbWV0YV9wYXJzZS5weQ==) | `100.00% <100.00%> (ø)` | | | [dclab/rtdc\_dataset/check.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvcnRkY19kYXRhc2V0L2NoZWNrLnB5) | `96.17% <100.00%> (-0.82%)` | :arrow_down: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/DC-analysis/dclab/pull/227/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulmueller commented 1 year ago

FYI seems like GitHub is able to merge this without any rebasing on your end.

paulmueller commented 1 year ago

The tests now fail only because the regexp is not fully matching after the changes we made today.

PinkShnack commented 1 year ago

The tests now fail only because the regexp is not fully matching after the changes we made today.

Fixed in https://github.com/DC-analysis/dclab/pull/227/commits/7f16bd054e02fb90ae8b2279eade46d8e68c6f58

FYI seems like GitHub is able to merge this without any rebasing on your end.

Even after I would update the changelog...? :D

PinkShnack commented 1 year ago

So now I am waiting on two things:

  1. Numpy on windows needs to be fixed.
  2. I need to use this branch to test my pipeline to verify that all the metadata is correctly included!
PinkShnack commented 1 year ago

FYI I built ShapeOut2 with this branch of dclab and I can open the features. Everything seems to work as normal.

paulmueller commented 1 year ago

Sorry, I cannot review the current state, because GitHub is asking me to review all of the commits I made since the tree diverged for this PR.

PinkShnack commented 1 year ago

Sorry, I cannot review the current state, because GitHub is asking me to review all of the commits I made since the tree diverged for this PR.

Yeah this is annoying. I dont think I merged or rebased, so why are your changes included? It is a pity we can't compare this branch with the current main...

Also, I haven't changed the changelog...

paulmueller commented 1 year ago

This is how to fix this "bug" which is "by design" by GitHub: https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch

(highest voted answer says: click edit, change the base branch, then change it back).

PinkShnack commented 1 year ago

FYI the docs build for me locally.