Make sure basins are not forgotten when running CLI methods (e.g. dclab-compress)

DC-analysis / dclab

Python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets

https://dclab.readthedocs.io

Other

11 stars 12 forks source link

Make sure basins are not forgotten when running CLI methods (e.g. dclab-compress) #239

Closed paulmueller closed 7 months ago

paulmueller commented 1 year ago

These CLI commands should include basin definitions: compress, condense, repack This CLI command should include mapped basin definitions: split This CLI command should not include basin definitions: join

NadiaSbaa commented 10 months ago

We have implement the test function test_basin_preserved_compress() here

paulmueller commented 10 months ago

Added the bug label, since this is actually not correctly implemented at all.

[EDIT: It was actually implemented correctly, the test function we came up with copied over scalar features which is why it did not actually test the thing]

paulmueller commented 7 months ago

closed in https://github.com/DC-analysis/dclab/commit/abc9c44a65384a2e9c8e9ebc70d506d4aa846ffd