Closed maxschloegel closed 10 months ago
Attention: 48 lines
in your changes are missing coverage. Please review.
Comparison is base (
8eb38a0
) 75.54% compared to head (bd8c699
) 73.01%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The errors thrown above are the DCOR-issues you, @paulmueller , were talking about, right?
Tests failing is not related to this PR.
Looks good to me. Can I merge?
Yes!
In this MR we refactor all
functools.lru_cache
decorators on instance methods, since they introduce memory-leak.Currently the only class that still contains
lru_cache
-decorators for instance methods isDCORTraceItem
indclab.rtdc_dataset/fmt_dcor/events.py
. There are going to be future refactoring steps that will remove these.