search

DC-analysis / dclab

Python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets
https://dclab.readthedocs.io
Other
10 stars 12 forks source link

Update feat_const.py with new cell feat calculated from the raw cnt #241

Closed SaraKaliman closed 10 months ago

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (990ff7f) 91.25% compared to head (8e2a681) 91.25%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #241 +/- ## ======================================= Coverage 91.25% 91.25% ======================================= Files 110 110 Lines 7798 7798 ======================================= Hits 7116 7116 Misses 682 682 ``` | [Files](https://app.codecov.io/gh/DC-analysis/dclab/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis) | Coverage Δ | | |---|---|---| | [dclab/definitions/feat\_const.py](https://app.codecov.io/gh/DC-analysis/dclab/pull/241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DC-analysis#diff-ZGNsYWIvZGVmaW5pdGlvbnMvZmVhdF9jb25zdC5weQ==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulmueller commented 10 months ago

Please remember to update the changelog.

SaraKaliman commented 10 months ago

btw. I noticed that pos_x is registered ["pos_x", "Position along channel axis [µm]"] but not the pos_y. Is this a bug or on purpose?

paulmueller commented 10 months ago

btw. I noticed that pos_x is registered ["pos_x", "Position along channel axis [µm]"] but not the pos_y. Is this a bug or on purpose?

I don't understand the question. Both pos_x and pos_y are defined.

https://github.com/DC-analysis/dclab/blob/4495480020fe63b1c53c69e2fde631ba3c7f40c0/dclab/definitions/feat_const.py#L72-L75