search

DC-analysis / dclab

Python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets
https://dclab.readthedocs.io
Other
10 stars 12 forks source link

Enable RTDC copier to accept list of features #247

Closed RaghavaAlajangi closed 9 months ago

RaghavaAlajangi commented 9 months ago

This pull request is aimed at enabling dclab.rtdc_dataset.copier to accept a list of feature strings that can be copied from the source RTDC file to the destination RTDC file.

This allows us to include a CLI option to write a specified list of features as mentioned in #246.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6fef6c1) 91.27% compared to head (4f97b0a) 91.24%.

Files Patch % Lines
dclab/rtdc_dataset/copier.py 76.92% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 91.27% 91.24% -0.03% ========================================== Files 115 115 Lines 7848 7856 +8 ========================================== + Hits 7163 7168 +5 - Misses 685 688 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RaghavaAlajangi commented 9 months ago

Dont we need tests for missing lines of code?

paulmueller commented 9 months ago

Yes, would be good to have them. You up for another PR?

RaghavaAlajangi commented 9 months ago

Yes, I will create a new PR with those changes.