search

DC23 / scriptabit

Python scripting for Habitica
Apache License 2.0
8 stars 4 forks source link

Check that new pet types are handled by the petcare plugin #28

Closed DC23 closed 7 years ago

DC23 commented 7 years ago

Some new pets have been released since the pet care code was last updated. The code should be checked to make sure the new pets are handled.

DC23 commented 7 years ago

New quest pets are already handled, since anything not in the base or special pet list is treated as a quest pet.

DC23 commented 7 years ago

However, I do need to manually add a few of the seasonal hatching potions.

DC23 commented 7 years ago

I have updated the pet code so that quest pets and magic potions are identified implicitly (any pet that is not a base pet but uses a base potion is a quest pet, and any pet that doesn't use a base potion is a magic pet). This means that the pet code should now remain up to date when new quest pets or magic potions are added. The only changes that will require manual handling in future are changes to the base potions or pets, and new Rare Pets. Rare pets cannot be identified automatically since there is no consistent pattern to their use. For example, the Polar Bear rare pet has code 'BearCub-Polar'. This would make it look like a magic pet since the potion is not a base potion (polar). But as a rare pet it cannot be fed or hatched so should be ignored.

These changes will be in release 1.17.0