DC23 / scriptabit

Python scripting for Habitica
Apache License 2.0
8 stars 4 forks source link

Issues with new special potions: Bad Request #47

Closed therealmaxmoon closed 6 years ago

therealmaxmoon commented 6 years ago

scriptabit gives me bad request for new special potions trying to hatch a sheep.

command: sb-pets --hatch-pets --quest-pets --magic-pets --tags ''

output:

scriptabit version 2.0.2
verbose mode: False
Loading credentials from /home/maxmoon/.auth.cfg
Habitica API at 'https://habitica.com/api/v3/' is up
** pet_care running

Scriptabit Pet Care Services: looking after your pets since yesterday
pet_care update 0 @ Fri Feb  9 18:07:47 2018
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Thunderstorm
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Holly
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Peppermint
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Cupid
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Aquatic
400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Ember
:dragon: Hatched 0 new pets
tags:  []

** pet_care done
Exiting
DC23 commented 6 years ago

Not surprising. I put in code that tries to detect magic potions based on the name pattern, but maybe the new potions have a different name structure. I will have a look.

On 10 Feb 2018 01:14, "maxmoon" notifications@github.com wrote:

scriptabit gives me bad request for new special potions trying to hatch a sheep.

command: sb-pets --hatch-pets --quest-pets --magic-pets --tags ''

output:

scriptabit version 2.0.2 verbose mode: False Loading credentials from /home/maxmoon/.auth.cfg Habitica API at 'https://habitica.com/api/v3/' is up ** pet_care running

Scriptabit Pet Care Services: looking after your pets since yesterday pet_care update 0 @ Fri Feb 9 18:07:47 2018 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Thunderstorm 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Holly 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Peppermint 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Cupid 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Aquatic 400 Client Error: Bad Request for url: https://habitica.com/api/v3/user/hatch/Sheep/Ember :dragon: Hatched 0 new pets tags: []

** pet_care done Exiting

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DC23/scriptabit/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AGm0NmsEeghNmWYoqi863gY_0RPlLqeRks5tTH0SgaJpZM4SAPmO .

DC23 commented 6 years ago

finally got to look at this. It's not potion naming. the problem is that magic potions are not valid on quest pets. I will update the code to avoid that combination.