Closed scott-huberty closed 1 month ago
@scott-huberty thank you so much for working on this! makes sense that it was a permissions issue. I just want to confirm with @tjhendrickson before merging (he's currently OOO but will be back next week)
No problem! And on that note maybe we want to consider #86 before merging too? In which case we'd want to add a few lines of code to make sure we don't grant execute permissions to non-executable files.
Good point, thanks for the reminder. I'll work on getting this resolved next week!
No worries! We can incorporate #86 into this PR if it's easier. Happy to pick things up next week after @tjhendrickson is back in office.
@scott-huberty we've decided to hold off on #86 for now, but will merge your changes and tag a new release. thanks again for your work on this!
No problem and thanks @LuciMoore ! 🙏
Fixes #132 Fixes #133
Since the devs are already giving all users read+execute permissions to all files in
/home/bibsnet/src
, I am assuming that it is okay with the devs to extend this to/home/bibsnet/data
and/opt/nnUNet
Long story:
Both of the linked issues arose from file permission issues, specifically for
users
who are in theothers
permission group (i.e. not in theuser
orgroup
groups).For example, on
main
, if you enter into the docker container with:docker run -it --entrypoint /bin/bash dcanumn/bibsnet:latest
OR
singularity shell --nv --cleanenv --no-home /home/path/to/bibsnet.sif
These are the permissions for
/home/bibsnet/data
:models.csv
is unreadable for users in theothers
permission group. This causes bibsnet to crash: #132And:
In the docker image I get:
But in the singularity image I get:
others
permission group. This causes BIBSnet to crash with an error message that was hard to interpret:RuntimeError: Could not find a task with the ID 541.
: #133This was a really nasty one to debug.... I think it might be worth including a test that asserts that all files needed by BIBSnet give read+execute permissions to all users, to avoid a code regression in the future.