Include Dockerfile generator script for neurodocker in repo

DCAN-Labs / abcd-hcp-pipeline

bids application for processing functional MRI data, robust to scanner, acquisition and age variability.

https://hub.docker.com/r/dcanumn/abcd-hcp-pipeline

BSD 3-Clause "New" or "Revised" License

49 stars 19 forks source link

Include Dockerfile generator script for neurodocker in repo #23

Open DavidEWarrenPhD opened 4 years ago

DavidEWarrenPhD commented 4 years ago

The included Dockerfile appears to be generated using neurodocker, but a script containing the neurodocker call is not included in this repo. Including the neurodocker generator script would be convenient and would enhance reproducibility. Example at https://github.com/kaczmarj/neurodocker/blob/master/examples/conda_python/generate.sh.

ericearl commented 4 years ago

@DavidEWarrenPhD Thanks for pointing this out! We should remove most of that from the Dockerfile and credit kaczmarj for what came from their neurodocker. What happened was we used kaczmarj's neurodocker from DockerHub for the original first base Dockerfile build and just never deleted all the comments after we had basically rewiritten the whole Dockerfile. Regardless, I will leave this issue open until we make those corrections.