DCAN-Labs / abcd-hcp-pipeline

bids application for processing functional MRI data, robust to scanner, acquisition and age variability.
https://hub.docker.com/r/dcanumn/abcd-hcp-pipeline
BSD 3-Clause "New" or "Revised" License
49 stars 19 forks source link

Refactor Dockerfile to be consistent w/ nhp-abcd-bids-pipeline, infant-abcd-bids-pipeline #50

Closed madisoth closed 2 years ago

madisoth commented 2 years ago

After merge of https://github.com/DCAN-Labs/abcd-hcp-pipeline/pull/39 , we should be able to refactor the Dockerfile and use the same "layered" build approach as nhp-abcd-bids-pipeline and infant-abcd-bids-pipeline:

top layer: DCAN-HCP + BIDS wrapper + python mid layer: DCAN internal-tools (dcan_bold_proc, executivesummary, customclean etc.) bottom layer: external-software (Ubuntu, FSL, FreeSurfer, Workbench etc.)

Standardizing both the Docker build process and the versions of dependencies shared across pipelines will be a major plus for usability and maintainability.

madisoth commented 2 years ago

Addressed by #57; this issue can be closed upon merge.

arueter1 commented 2 years ago

This has been merged. Closing issue.