Updating conda environment + fixed deprecated commands + resampling with multiprocessing

DCASE-REPO / DESED_task

Domestic environment sound event detection task

MIT License

126 stars 67 forks source link

Updating conda environment + fixed deprecated commands + resampling with multiprocessing #66

Closed florian-angulo closed 1 year ago

turpaultn commented 1 year ago

Please

update the docstrings with asteroid schedulers being cited (in the sed_trainer of the different versions)
Update desed_task to 0.1.1
In the README, add - desed_task 0.1.0 to run 2022 and 2021 baseline (maybe give a way to install it (pip install with the right @ pointing to the right commit), or give the commit to use since we don't have it in pypi)
Other comments with the review

Thank you so much for your work !! 😁

florian-angulo commented 1 year ago

Ok will do !

florian-angulo commented 1 year ago

As you suggested, I put in each recipe a specific requirements.txt and updated accordingly each conda_create_environment.sh. I didn't mention in the README for now that the two previous baselines are using desed_task 0.1.0 but there is now a pip install pointing to the latest commit of the 2022 edition in each sh script.

florian-angulo commented 1 year ago

Thank you @turpaultn for the review ! I think we can merge this PR now. I'll submit a later one to provide a stricter dcase2023 environment install.