search

DCBIA-OrthoLab / Q3DCExtension

Apache License 2.0
4 stars 14 forks source link

Linear distance between two landmarks - wrong computation #70

Closed aruellas closed 3 years ago

aruellas commented 3 years ago

I noticed some other issues while using Q3DC... Doing measurements for ANS-Me, I thought they were a kind of small based on what I am used to get from patients in the clinic.

Fig 1: Then, I measured the distance between N and ANS (1), between ANS and Me (2), between N and Me (3). It was supposed that the S-I (vertical) component should work like 1 (N-ANS) + 2 (ANS-Me) = 3 (N-Me) but it is not even close...

Fig 2: Then, I tried another measurement to test it. I measured the linear distances from A point to B point and from B point to A point and the results were different...

I tried an older version of Q3DC (3D Slicer 4.7.0-2016-12-12) and it worked well (correct values attached to this message), although the distance between a line and a point is not working properly that older version.

Hope it helps to improve the tool. Thank you!

Screen Shot correct values Screen Shot Figure 1 Screen Shot Figure 2
allemangD commented 3 years ago

Thanks for including the extra details! I'm planning to work on this Thursday.

jcfr commented 3 years ago

Let me know if you want some help. In the meantime, I will archive the corresponding emails.

On Tue, Apr 20, 2021 at 3:09 PM David Allemang @.***> wrote:

Thanks for including the extra details! I'm planning to work on this Thursday.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DCBIA-OrthoLab/Q3DCExtension/issues/70#issuecomment-823531596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVPIYYZ2RSWFJH6WA6CQLTJXGNDANCNFSM43IZ3ZTA .

luciacev commented 3 years ago

@jcfr @allemangD @bpaniagua @aruellas I am working to explain further issue #70 reported by Antonio:•this issue does not occur in Slicer 4.11 stable extension SlicerCMF downloaded 3 weeks ago or the old SlicerCMF 4.1 compilation •this issue occurs in Slicer 4.11 stable extension SlicerCMF downloaded after the changes made last week •this issue does not occur for landmarks distances  within the same VTK model •this issue occurs for landmarks distances  between different models Please see attached screenshots detailing the bullet points above: 

Screen Shot 2021-04-21 at 11 25 37 PM Screen Shot 2021-04-21 at 11 25 40 PM Screen Shot 2021-04-21 at 11 25 42 PM Screen Shot 2021-04-21 at 11 25 45 PM

Please let me know if we need to set up a Zoom meeting to clarify if you still have doubts and counting on your support. I am available today Thursday anytime except between 2-4 PM or Friday 11AM-1PM. Thanks so much, Lucia

aruellas commented 3 years ago

Thank you!!!

Em qui., 22 de abr. de 2021 às 10:22, David Allemang < @.***> escreveu:

Closed #70 https://github.com/DCBIA-OrthoLab/Q3DCExtension/issues/70 via #71 https://github.com/DCBIA-OrthoLab/Q3DCExtension/pull/71.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DCBIA-OrthoLab/Q3DCExtension/issues/70#event-4631187766, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLUS23PGV475X2NODUZV2DTKAWJ3ANCNFSM43IZ3ZTA .