search

DCBIA-OrthoLab / Q3DCExtension

Apache License 2.0
4 stars 14 forks source link

Cannot use landmarks with name containing `'` #75

Closed luciacev closed 2 years ago

luciacev commented 2 years ago

@allemangD @bpaniagua @jcfr @aruellas Hi David When we upload a fiducial list and legend or even when we just place the landmarks in Q3DC, the dropdown menu to "select landmarks" is not working and when we try to make measurements, again the dropdown menus do not show the landmarks and we cannot make measurements. Dylan shared our video recording with you. We tested this issue both in my laptop and Dylan's that have the most updated SlicerCMF extension, so something might have changed that is now causing this issue. Dylan needs to make progress in his project this week Can you please prioritize addressing this issue and let us know what you find out? Thank you so much! Lucia

luciacev commented 2 years ago

Issue solved on user side! The issue was the way Dylan had created the fiducial list. I had tested his fiducial list and had created the issue. But I just realized that the issue does not happen when I create the fiducial list. :-)

allemangD commented 2 years ago

@luciacev clarified in an email (I'm removing user-specific details for brevity here):

[...] the drop down menus stopped for you after UL1 and the next landmark was UR1', I realized the issue may have been the landmark naming as the Q3DC code may not like apostrophes. :-)

[...]

[...] the issue was solved changing the name of the landmarks with an ' from for example UR1' to UR1A. I hope it is clear for you now that the issue is just that the legend cannot contain the '. It is common in landmark naming for root apex or soft tissue that users may choose to name it with an '. [...]

I am able to reproduce this; indeed attempting to place a landmark containing ' in the name causes the landmark combobox to fail to populate. I've updated the title of this issue to reflect that.

luciacev commented 2 years ago

@allemangD Thanks so much David!!