DCBIA-OrthoLab / Q3DCExtension

Apache License 2.0
4 stars 14 forks source link

Error Computing Angle between 2 lines that include a midpoint of that missing landmark when the T1/T2 box is checked #82

Open HUTIN1 opened 2 years ago

HUTIN1 commented 2 years ago

Somewhere in the code, that I could not identify where, there is an argument that skips a measurement for a landmark if this landmark is missing for a case/patient in a folder of patients' landmark lists. The issue is for computing Angle between 2 lines that include a midpoint of that missing landmark when the T1/T2 box is checked : the computation of the measurements with the midpoint fail for all cases if a single case does not have the landmark. We get the following keyerror : please see screenshot.

The users are going around this bug by computing Angle between 2 lines that include a midpoint of that missing landmark only at T, and then computing it again at T2, and in this case of computing it for a single time point , the code knows to skip the case that does not have the landmark.

Screenshot from 2022-08-05 14-48-51

luciacev commented 2 years ago

@Hutin1 @allemangD @jcfr @lucanchling @bianchijonas1 I just realized we forgot to note that this issue is regarding the AQ3DC code and not Q3DC. :-) Thanks!