DCBIA-OrthoLab / ShapeVariationAnalyzer

Shape modeling and classification, extract shape features
Apache License 2.0
8 stars 22 forks source link

Python requirements need to be updated for latest Slicer python version #55

Closed jamesobutler closed 2 years ago

jamesobutler commented 2 years ago

Similar to what is needed at https://github.com/DCBIA-OrthoLab/MFSDA_Python/issues/26

Slicer recently upgraded from Python 3.6.7 to Python 3.9.10 in https://github.com/Slicer/Slicer/commit/34e48e8aef5dad19ec8a955d6f48a1940846e3f3. There are now observed build errors of the ShapeVariationAnalyzer Slicer extension as seen at https://slicer.cdash.org/viewBuildError.php?buildid=2618477. This is because the python requirements file in the repo is including hashes that are only for Python 3.6 wheels. These need to be updated for Python 3.9 wheels which also means the actual version of packages here will need to be updated as some older versions simply don't have Python 3.9 wheels because that version was released before Python 3.9 was even released. For example scikit-learn==0.23.1 does not have Python 3.9 wheels available from PyPI (see here).

https://github.com/DCBIA-OrthoLab/ShapeVariationAnalyzer/blob/9eb71073e4e782ab9a44f3ba708793735ac0c9c4/SuperBuild/External_python-ShapeVariationAnalyzer-requirements.cmake#L43-L54

jamesobutler commented 2 years ago

Closed by https://github.com/DCBIA-OrthoLab/ShapeVariationAnalyzer/commit/03a9b78ae9fb23802994e344bb18bb46d68d9a85.