search

DCBIA-OrthoLab / SlicerAutomatedDentalTools

A 3D Slicer extension to use AMASSS, ALI-CBCT and ALI-IOS
Other
86 stars 26 forks source link

BUG : fix import function #106

Closed GaelleLeroux closed 4 months ago

GaelleLeroux commented 4 months ago

Hi @allemangD !

I forgot to manage the pip install in the first pull request so I'm doing it now

Thank you :)

GaelleLeroux commented 4 months ago

Hi @allemangD !

I saw you accept it but I added a new commit to change a little the UI. Could you merge it if it's ok ?

Thank you :)

allemangD commented 4 months ago

For similar reason to https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/pull/107#discussion_r1699009967, should not manage vtk with pip_install or pip_uninstall.

I searched for references to vtk and found usage in:

There are also references in these modules, but they are not a problem since they are executed in the Conda environment:

I also found another reference to numpy in FlexReg; I missed it in my prior search because it was written 'numpy<2'.

These are removed in c1016dbde8aa4d918546f71df2dd5934c335a1df and 1582bdf27fe7117943113fad3819bdf9a5b362d8

Note I rebased on main after merging the other PRs to be sure to catch all usages, hence the force-push.