search

DCBIA-OrthoLab / SlicerAutomatedDentalTools

A 3D Slicer extension to use AMASSS, ALI-CBCT and ALI-IOS
Other
79 stars 22 forks source link

FIX : error import #98

Closed GaelleLeroux closed 2 months ago

GaelleLeroux commented 2 months ago

Hi @allemangD !

In Slicer preview SlicerAutomatedDentalsTools cannot be built because the CondaSetUp import failed. I've tried to fix it, can you tell me if it will work and if so merge it ?

Thank you ! Gaelle

allemangD commented 2 months ago

We should apply this for consistency, but it is already applied in the extensions index. I don't expect this to fix any error.

https://github.com/Slicer/ExtensionsIndex/blob/main/AutomatedDentalTools.json#L3

SlicerAutomatedDentalsTools cannot be built

Are you trying to build locally with CMake? You'll need to install SlicerConda for your development environment manually.

GaelleLeroux commented 2 months ago

No I didn't tried to build it locally. Creating a Slicer local build to test our extension is very long and the one we're having is not accessible right now. I tried to fix it quickly based on the error in the dashboard but you're right I sould try to build it locally with CMake

GaelleLeroux commented 2 months ago

@allemangD

I tried to change the name of the project to be consistent with th eAutomatedDentalsTools.json file in Slicer/ExtensionIndex. I'm not having any error building it manually and the error we saw in the dashborad seems to be link to the json. What do you think ? Do you think it will work ? If so can you merge it ?

allemangD commented 2 months ago

Thanks @GaelleLeroux - merging now.

For reference the current dashboard is https://slicer.cdash.org/viewBuildError.php?buildid=3392250; since the ExtensionsIndex has AutomatedDentalTools.json I agree that this should fix the issue.