DCC-EX / CommandStation-EX

EX-CommandStation firmware from DCC-EX. Includes support for WiFi and a standalone WiThrottle server. A complete re-write of the original DCC++.
https://dcc-ex.github.io/
GNU General Public License v3.0
155 stars 107 forks source link

SH1106 OLED Display Offset Fix #169

Closed Neil-McK closed 3 years ago

Neil-McK commented 3 years ago

Correct display offset for SH1106. The SH1106 supports 132 columns but most displays use 128 column OLED, connected to the middle columns 2-129.

Neil-McK commented 3 years ago

Fixes issue #170.

FrightRisk commented 3 years ago

Pretty simple fix. The reset issue concerns me a bit. Some displays work differently than others. I have a .96" display laying around I can solder up, but I don't think that helps in this case.

Neil-McK commented 3 years ago

The SH1106 seems to be used exclusively for 1.3" displays, and 0.96" displays are used with the SSD1306 controller. The out-of-the-box I2C version of the SH1106 seems to be fine, so it may be just the way I've modified the SPI device that caused the behaviour I observed on power up. This fix certainly resolves the reported issue #170, so shall I merge it?

FrightRisk commented 3 years ago

I'm here replying, so I'll just do it ;) Thanks!