search

DCC-EX / WebThrottle-EX

WebThrottle-EX is a web based (html,jQuery,JavaScript) Controller/Throttle for DCC-EX EX-CommandStations
https://dcc-ex.com/WebThrottle-EX
GNU General Public License v3.0
21 stars 14 forks source link

Unified settings page #14

Closed matt-vdv closed 3 years ago

matt-vdv commented 3 years ago

What does everyone think of the unified settings page?

ManiAkasapu commented 3 years ago

I added multi throttle functionality and Theme switching functionality. You can test it from my branch Webthrottle-Mani

matt-vdv commented 3 years ago

@ManiAkasapu I will have a look at that!

matt-vdv commented 3 years ago

@ManiAkasapu Good start!

I like the themes; they look really nice and good to have them. I really like the metal one. With the dark theme, I'm just wondering if it should be dark gray rather that full black?

By the way, you might want to merge the master branch into your dev branch. It appears you just missed some of the changes I made to make the emulator fully functional and add features such as not allowing cabs to be acquired when there is no connection.

ManiAkasapu commented 3 years ago

@matt-hu I have introduced the menu. It would be good if you link the toggle between Settings and Throttle to side menu I introduced.

  1. Show Settings block when User clicks on Left menu-item settings.
  2. Click on Throttle menu to go back to Throttle.
ManiAkasapu commented 3 years ago
image
matt-vdv commented 3 years ago

@ManiAkasapu That looks great! I will try and link my page when I get some time.

The way you have done it is better than my method, the information link is rather neat as well. Perhaps you could add a link on the information pane to the help page?

matt-vdv commented 3 years ago

@ManiAkasapu I have done the initial work, it would be helpful if you could merge into your branch as I keep getting merge conflicts when pulling your changes to the unified-settings branch. At the time of writing, there are no conflicts between Webthrottle-Mani and unified-settings, so you shouldn't have any problems there.

ManiAkasapu commented 3 years ago

@matt-hu You mean with unified-settings branch?

ManiAkasapu commented 3 years ago

@matt-hu One suggestion on settings page format is just to follow "Github" repository settings. Screenshot below:

image
ManiAkasapu commented 3 years ago

@matt-hu I keep forgetting asking you if you are on discord? If you are please ass me to friends list. BTW, Thanks for your great work and managing the repository, release & streamlining the processes. I, myself is not a developer. so, I could not do all these my self.

matt-vdv commented 3 years ago

@ManiAkasapu unified-settings is the one, yes

@matt-hu One suggestion on settings page format is just to follow "Github" repository settings. Screenshot below:

image

I'm not quite sure what you mean here. (Also, I don't have access to the repos settings)

Sorry, I'm not on discord but you can always email me at matt.hu1@outlook.com if needed.

ManiAkasapu commented 3 years ago

@matt-hu I made some CSS & HTML structural changes. Hope you do not mind. You can fetch them from my branch. This is the idea I am talking about. Its nice you used flex.

matt-vdv commented 3 years ago

@ManiAkasapu Thanks for the CSS work! Much better than mine...

ManiAkasapu commented 3 years ago

BTW, I merged to your branch too.

matt-vdv commented 3 years ago

@ManiAkasapu Yep saw that, thanks!

Currently working on the storage page...

matt-vdv commented 3 years ago

@ManiAkasapu BTW, I have pushed to unified-settings with some additions to the storage page

I was wondering if a legacy mode would be a good idea. This would allow us to use the new features on command station whilst still supporting basestation-ex (legacy mode on - no new commands used, legacy mode off - we can use the new commands such as the <F cab function state> for functions)?

ManiAkasapu commented 3 years ago

@ManiAkasapu BTW, I have pushed to unified-settings with some additions to the storage page

I was wondering if a legacy mode would be a good idea. This would allow us to use the new features on command station whilst still supporting basestation-ex (legacy mode on - no new commands used, legacy mode off - we can use the new commands such as the <F cab function state> for functions)?

Actually, Currently we support only legacy commands.. First we have to support these new (EX) commands.. I would be great if you can have table comparing legacy and new commands.. I can add those functions..

Depending on that , I have 2 different ideas,

  1. Just send both of them
  2. Send command depending on setting you are talking about.

so I can think this... Option1: Support Classic [ ✓] - Sends both command types. Uncheck this - sends new commands Option2: select box to select Type of command station Depends on the selection we send the command.

Sent from mobile..

ManiAkasapu commented 3 years ago

@matt-hu Another option is forget about setting.. just send both by default.. Later as EX got popular remove support for DCC++ Classic.

ManiAkasapu commented 3 years ago

@matt-hu You can find all commands in "commandController.js"

matt-vdv commented 3 years ago

@ManiAkasapu sending both could work, for now at least. At the moment, the only new command I am aware of is the new functions command. However, in the future new commands could be introduced that don't have an alternative in DCC classic. I suppose we don't really need to worry about this yet, just an idea we might need in the future...

ManiAkasapu commented 3 years ago

One suggestion for Settings screen is not to hide Blocks just stack them one below each. When you click on the side menu item just scroll it to top. However we will not have settings that many. What do you think?

matt-vdv commented 3 years ago

@ManiAkasapu Yes! That could work well!

How about the blocks don't change order, but it moves the block into view. An example of this is the chrome settings panel?

ManiAkasapu commented 3 years ago

@ManiAkasapu Yes! That could work well!

How about the blocks don't change order, but it moves the block into view. An example of this is the chrome settings panel?

Yes. that's what I meants. Like $.scrollTo("#blockx"):

matt-vdv commented 3 years ago

@ManiAkasapu That should work well! Well done for coming up with that idea!

matt-vdv commented 3 years ago

@ManiAkasapu, the unified-settings branch now has the scrolling feature you talked about.

ManiAkasapu commented 3 years ago

@matt-hu @FrightRisk I have merged all the proposed changes to Master. Please it before closing it.

matt-vdv commented 3 years ago

@ManiAkasapu Thanks for that! Development is moving really fast at the moment... I'll test it when I get some time, then we can think about moving on to new features!

Over time, we will probably think of new settings to add, but at the moment they are all where they need to be. I must say, this work has made the UI much cleaner, it is looking great!

ManiAkasapu commented 3 years ago

@ManiAkasapu sending both could work, for now at least. At the moment, the only new command I am aware of is the new functions command. However, in the future new commands could be introduced that don't have an alternative in DCC classic. I suppose we don't really need to worry about this yet, just an idea we might need in the future...

@matt-hu this is some think we should also discuss with @FrightRisk . He knows all types of commands and modes.. @FrightRisk please provide us the EX command list (some where I saw).

matt-vdv commented 3 years ago

@ManiAkasapu Yes I agree we should ask @FrightRisk. There is a command list located in the control station wiki, found here

ManiAkasapu commented 3 years ago

@matt-hu Can you create a issue for above and close this?