search

DCC-EX / WebThrottle-EX

WebThrottle-EX is a web based (html,jQuery,JavaScript) Controller/Throttle for DCC-EX EX-CommandStations
https://dcc-ex.com/WebThrottle-EX
GNU General Public License v3.0
21 stars 14 forks source link

Speed commands not displaying in Debug area #22

Closed ManiAkasapu closed 3 years ago

ManiAkasapu commented 3 years ago

When I am changing speed value (in emulator mode) debug box not showing the respective speed commands. Not sure this is happening only on emulator or serial too. @matt-hu @FrightRisk Please test if speed commands are getting sent out to the Loco.

ManiAkasapu commented 3 years ago

Just tested (emulator) in 1.1.0. It is working there. @matt-hu Can you look at it?

matt-vdv commented 3 years ago

@ManiAkasapu thanks for highlighting this. I will test this later and try and fix add soon as possible Is it the master break where the issue is?

matt-vdv commented 3 years ago

Just checked, there are no speed commands being sent to the command station so I will need to investigate this further.

matt-vdv commented 3 years ago

@ManiAkasapu, I think this is now fixed. Do you want to double check to make sure (the fix is in master by the way)

ManiAkasapu commented 3 years ago

@ManiAkasapu, I think this is now fixed. Do you want to double check to make sure (the fix is in master by the way) @matt-hu Thankyou. Can you check it's only for Knob type or other sliders are also effected? I commented that because, I am sending commands from setSpeedofControllers() function (inside you see the call) I assume knob type has the condition 

if (oldValue != kval) {
setSpeedofControllers();
}

Which may cause the issue.

But if other types (vertical, circular) also not working then I have to look at my code.

matt-vdv commented 3 years ago

@ManiAkasapu All sliders were affected, what I did was uncommented line 440 in exWebThrottle.js

ManiAkasapu commented 3 years ago

@ManiAkasapu All sliders were affected, what I did was uncommented line 440 in exWebThrottle.js

Thanks @matt-hu. That line only applies to Knob type throttle.. I wonder if other types are working without this fix..

matt-vdv commented 3 years ago

@ManiAkasapu, thanks for that. As far as I am aware, using code in the master branch, all is now working. Do you want to check this to make sure this is the case?

ManiAkasapu commented 3 years ago

@ManiAkasapu, thanks for that. As far as I am aware, using code in the master branch, all is now working. Do you want to check this to make sure this is the case?

Yes. Please..

ManiAkasapu commented 3 years ago

Verified.