Report of no return values being sent to the log

[FrightRisk]

User reports that the Arduino serial monitor sees all the returns from commands but web throttle bdoes not. Will check today. Using 3.0.0 of CS-EX and current release of throttle

[matt-vdv]

@FrightRisk Ok, I will investigate later...

I don't have an Arduino on me at the moment, also will need to flash CS v3 as haven't got round to it yet.../

[matt-vdv]

Ok, I can confirm that this bug exists. I will start working on a fix.

[FrightRisk]

Thanks Matt

On Sat, Dec 12, 2020, 6:11 AM Matt notifications@github.com wrote:

Ok, I can confirm that this bug exists. I will start working on a fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DCC-EX/WebThrottle-EX/issues/47#issuecomment-743740391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI36OWHWI7YD3SO6XYXMQRTSUNFVHANCNFSM4UOS4Y6Q .

[matt-vdv]

Ok, so I have tracked down the bug! It took some time as it is fairly low level... I'm not sure that it ever worked, seeing what the cause is...

What is happening is anything given to the displayLog() function inside a <> is added as a html tag, rather than as text.

I am working on a fix, not quite sure how to do it yet but a bit of research should help!

[matt-vdv]

@FrightRisk I have finished the fix in the branch matt-bugfix. I have also taken the opportunity to neaten up the debug console and bring the way the emulator and serial responses in line with each other.

Do you want me to issue a patch (version 1.3.1) or just leave it for now? I am more inclined towards releasing a patch as it is a fairly major bug, but I wanted your opinion

[FrightRisk]

I agree with you on the patch. Go ahead. Thanks!

On Wed, Dec 16, 2020, 11:17 AM Matt notifications@github.com wrote:

@FrightRisk https://github.com/FrightRisk I have finished the fix in the branch matt-bugfix. I have also taken the opportunity to neaten up the debug console and bring the way the emulator and serial responses in line with each other.

Do you want me to issue a patch (version 1.3.1) or just leave it for now? I am more inclined towards releasing a patch as it is a fairly major bug, but I wanted your opinion

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DCC-EX/WebThrottle-EX/issues/47#issuecomment-746563249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI36OWEM2NC2J43OHPSGFL3SVDMQPANCNFSM4UOS4Y6Q .

[matt-vdv]

Relase made and deployed to the build branch!

[matt-vdv]

@FrightRisk, by the way, could you let me know the user who reported this so they can be thanked on the release?

[FrightRisk]

I've tried to find the user and can't! I'll go again through all the places where people leave comments and see if I can find them. Merry Christmas if you celebrate it.

Fred

On Wed, Dec 16, 2020 at 3:46 PM Matt notifications@github.com wrote:

@FrightRisk https://github.com/FrightRisk, by the way, could you let me know the user who reported this so they can be thanked on the release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DCC-EX/WebThrottle-EX/issues/47#issuecomment-746989072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI36OWGBXDEAK2EZFI2VC7DSVEMD7ANCNFSM4UOS4Y6Q .

[matt-vdv]

Oh never mind then, if you find them, let me know...

Have a good Christmas yourself! I probably won’t be doing much till the new year, so you probably won’t hear from me much till then...