search

DCGM / pero_ocr_web

BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Replace postgres: by postgresql: for database_url #87

Open stweil opened 2 years ago

stweil commented 2 years ago

The latest versions of SQLAlchemy no longer support "postgres:". That old URL form was deprecated more than 10 years ago:

https://github.com/sqlalchemy/sqlalchemy/blob/8fc5005dfe3eb66a46470ad8a8c7b95fc4d6bdca/lib/sqlalchemy/dialects/postgres.py

Signed-off-by: Stefan Weil sw@weilnetz.de

stweil commented 2 years ago

See also https://github.com/sqlalchemy/sqlalchemy/issues/6083#issuecomment-801478013.

There are also some files which use SQLite (sqlite:///) instead of PostgreSQL. Which database software is preferred? Should both work?

Perhaps the code could use database_url = args.database, so the database argument would provide the full URL and the user were free to choose either SQLite or PostgreSQL.