search

DCIT / perl-Crypt-JWT

Other
54 stars 18 forks source link

verify_xxx options do not work with decode_payload=0 #31

Closed mnz2000 closed 2 years ago

mnz2000 commented 3 years ago

This is kind of obvious when one thinks about it, but I didn't. Spent some time wondering why verify_aud didn't work. I could imagine someone not testing for verify_xxx failures and thinking everything works when verification in fact doesn't happen at all.

Possible fixes:

  1. Croak if verify_xxx options are specified with decode_payload=0.

  2. Add a mention about it in the POD under decode_payload.

karel-m commented 3 years ago

Could you please check the patch above?

mnz2000 commented 3 years ago

Looks good to me.