search

DCIT / perl-CryptX

https://metacpan.org/pod/CryptX
Other
35 stars 23 forks source link

Remove -flto=auto #66

Closed Hugmeir closed 3 years ago

Hugmeir commented 3 years ago

Makefile.PL is removing -flto, and if the original line had -flto=auto, it then causes compilation to file.

Reproducible on a fedora docker image:

;  dnf check-update
;  dnf install -y perl curl
;  curl -L https://cpanmin.us | perl - App::cpanminus
;  cpanm -v CryptX

Which throws this error:

...
cd src && make ARFLAGS="cr" RANLIB=":" AR="ar" CC="gcc" LIB_EXT=.a OBJ_EXT=.o CFLAGS="-D_REENTRANT -D_GNU_SOURCE -O2 =auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fPIC   -g"
make[1]: Entering directory '/root/.cpanm/work/1606752895.2028/CryptX-0.069/src'
gcc -Iltm -Iltc/headers -DLTC_SOURCE -DLTC_NO_TEST -DLTC_NO_PROTOTYPES -DLTM_DESC -D_REENTRANT -D_GNU_SOURCE -O2 =auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fPIC   -g -DARGTYPE=4 -c ltc/ciphers/anubis.c -o ltc/ciphers/anubis.o
gcc: error: =auto: No such file or directory
make[1]: *** [Makefile:196: ltc/ciphers/anubis.o] Error 1
make[1]: Leaving directory '/root/.cpanm/work/1606752895.2028/CryptX-0.069/src'
make: *** [Makefile:1941: src/liballinone.a] Error 2
FAIL

With the patch applied, it builds & passes tests.

charsbar commented 3 years ago

@karel-m Glad to see this fix. Coud you please release a new version with this fix to CPAN?

karel-m commented 3 years ago

Sorry, just released as CryptX-0.070

charsbar commented 3 years ago

Thank you!