Open jcowey opened 7 years ago
@wsalesky as discussed in our Skype call, can you write a script to hunt down some/any examples of this?
Here is a list of matching bibl records: https://github.com/papyri/idp.data/blob/master/Biblio/4/3034.xml: M.P.E.R., N.S. I https://github.com/papyri/idp.data/blob/master/Biblio/4/3073.xml: P.S.I. X, 1 https://github.com/papyri/idp.data/blob/master/Biblio/4/3335.xml: O. Mich. I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/4/3394.xml: P.S.I. XI - DONE https://github.com/papyri/idp.data/blob/master/Biblio/4/3889.xml: M.P.E.R., N.S. III https://github.com/papyri/idp.data/blob/master/Biblio/5/4258.xml: M.P.E.R., N.S. IV - DONE https://github.com/papyri/idp.data/blob/master/Biblio/5/4392.xml: P.Lugd.Bat. IV https://github.com/papyri/idp.data/blob/master/Biblio/5/4494.xml: P.S.I. XIII, 1 https://github.com/papyri/idp.data/blob/master/Biblio/5/4667.xml: P.S.I. XII, 2 https://github.com/papyri/idp.data/blob/master/Biblio/5/4919.xml: P.S.I. XIII, 2 https://github.com/papyri/idp.data/blob/master/Biblio/6/5513.xml: P.S.I. XIV https://github.com/papyri/idp.data/blob/master/Biblio/8/7044.xml: Ch.L.A. IV https://github.com/papyri/idp.data/blob/master/Biblio/8/7585.xml: O. Wilcken - DONE https://github.com/papyri/idp.data/blob/master/Biblio/9/8062.xml: Pap.Graec.Mag. 1 - DONE https://github.com/papyri/idp.data/blob/master/Biblio/9/8361.xml: Papyri Graecae Magicae - DONE https://github.com/papyri/idp.data/blob/master/Biblio/9/8755.xml: O.Amst. - DONE https://github.com/papyri/idp.data/blob/master/Biblio/9/8888.xml: O. Saqqara https://github.com/papyri/idp.data/blob/master/Biblio/10/9035.xml: P.Tebt.Tait - DONE https://github.com/papyri/idp.data/blob/master/Biblio/10/9394.xml: O.Leid. - DONE https://github.com/papyri/idp.data/blob/master/Biblio/10/9672.xml: M.P.E.R., N.S. XIII - DONE https://github.com/papyri/idp.data/blob/master/Biblio/11/10361.xml: O.D.N. I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/12/11617.xml: O. Ashm. Shelton - DONE https://github.com/papyri/idp.data/blob/master/Biblio/12/11862.xml: T.Varie - DONE https://github.com/papyri/idp.data/blob/master/Biblio/13/12016.xml: Suppl. Mag. I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/13/12673.xml: O. Claud. I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/13/12729.xml: Suppl. Mag. II - DONE https://github.com/papyri/idp.data/blob/master/Biblio/14/13296.xml: P.PalauRib.Lit. - DONE https://github.com/papyri/idp.data/blob/master/Biblio/14/13309.xml: O.G.N. I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/14/13367.xml: M.P.E.R., N.S. XVII - DONE https://github.com/papyri/idp.data/blob/master/Biblio/15/14068.xml: P. Dublin - DONE https://github.com/papyri/idp.data/blob/master/Biblio/15/14684.xml: O. Claud. II - DONE https://github.com/papyri/idp.data/blob/master/Biblio/15/14778.xml: O.D.N. II - DONE https://github.com/papyri/idp.data/blob/master/Biblio/19/18001.xml: P. Paramone - DONE https://github.com/papyri/idp.data/blob/master/Biblio/19/18095.xml: P. Horak - DONE https://github.com/papyri/idp.data/blob/master/Biblio/19/18266.xml: Douch III https://github.com/papyri/idp.data/blob/master/Biblio/21/20297.xml: P.S.I. XV https://github.com/papyri/idp.data/blob/master/Biblio/21/20408.xml: M.P.E.R., N.S. XXXI - DONE https://github.com/papyri/idp.data/blob/master/Biblio/21/20517.xml: O. Abu Mina - DONE https://github.com/papyri/idp.data/blob/master/Biblio/22/21024.xml: O. Edfou I.F.A.O. - DONE https://github.com/papyri/idp.data/blob/master/Biblio/22/21045.xml: P. Narm. 2006 https://github.com/papyri/idp.data/blob/master/Biblio/22/21498.xml: O. Frangé - DONE https://github.com/papyri/idp.data/blob/master/Biblio/22/21621.xml: P. Prag. III - DONE https://github.com/papyri/idp.data/blob/master/Biblio/35/34232.xml: P.S.I. X, 2 https://github.com/papyri/idp.data/blob/master/Biblio/36/35110.xml: P. Lund I - DONE https://github.com/papyri/idp.data/blob/master/Biblio/77/76863.xml: P. Toronto Univ. Inv. F4107 https://github.com/papyri/idp.data/blob/master/Biblio/81/80609.xml: O. Xer. Inv. 48 https://github.com/papyri/idp.data/blob/master/Biblio/81/80636.xml: P. Scholl - DONE https://github.com/papyri/idp.data/blob/master/Biblio/82/81797.xml: O. Did. - DONE https://github.com/papyri/idp.data/blob/master/Biblio/82/81813.xml: P. Pintaudi - DONE https://github.com/papyri/idp.data/blob/master/Biblio/83/82190.xml: O. Petr. Mus. - DONE
over to you for analysis @jcowey
A note on how cases like this are currently (subsequent to changes now in review for #212) handled.
Consider TM 99590, where the following encoding is found:
<bibl type="publication" subtype="principal">
<ptr target="http://papyri.info/biblio/11862"/>
<biblScope unit="numbers">12</biblScope>
<!--ignore - start, i.e. SoSOL users may not edit this-->
<title level="s" type="abbreviated">T. Varie</title>
<!--ignore - stop-->
</bibl>
Because biblio 11862 does not have <title level="s" type="short-Checklist">
, we get the following in the HTML output:
<tr>
<th>Principal Edition</th>
<td>con i contributi di R.S. Bagnall, P. Cauderlier, A.E. Hanson e S. Pernigotti, appendice
di C. Federici, L. Mita e M. Pezzano, Tavolette lignee e cerate da varie collezioni. 12
</td>
</tr>
In these cases, current logic selects the first title found in the targeted biblio xml file.
I suspect @jcowey will eventually recommend different, perhaps more nuanced behavior.
@paregorios @jcowey This is why I added the bibl type parameter to the buildCitation template, this should make conditional displays a little easier.
It does not help that in the particular case of https://github.com/DCLP/idp.data/blob/master/Biblio/12/11862.xml the entry of the data is messed up. That will not be the only case of messed up data. The best of XSLTs cannot make sense of bad data. ;) I will sort that particular biblio file.
http://papyri.info/biblio/3034: M.P.E.R., N.S. I http://papyri.info/biblio/3073: P.S.I. X, 1 http://papyri.info/biblio/3889: M.P.E.R., N.S. III http://papyri.info/biblio/4392: P.Lugd.Bat. IV http://papyri.info/biblio/4494: P.S.I. XIII, 1 http://papyri.info/biblio/4667: P.S.I. XII, 2 http://papyri.info/biblio/4919: P.S.I. XIII, 2 http://papyri.info/biblio/5513: P.S.I. XIV http://papyri.info/biblio/7044: Ch.L.A. IV http://papyri.info/biblio/8888: O. Saqqara http://papyri.info/biblio/18266: Douch III http://papyri.info/biblio/20297: P.S.I. XV http://papyri.info/biblio/21045: P. Narm. 2006 http://papyri.info/biblio/34232: P.S.I. X, 2 http://papyri.info/biblio/76863: P. Toronto Univ. Inv. F4107 http://papyri.info/biblio/80609: O. Xer. Inv. 48
XSLT modifications to display all this were implemented with issue #269.
@jcowey have all the XML modifications you had in mind been implemented such that this ticket can be closed, or is there still work here to do?
ping @jcowey please see query preceding
When a DCLP file has
and the biblio file does not have
What sort of biblio files are we going to have to process? It will be necessary to try to be clear about the different categories.