DCLP / dclpxsltbox

Sandbox for development, testing, and review of XSLT for DCLP
http://dclp.github.io/dclpxsltbox/
1 stars 5 forks source link

Not all Principal Editions displaying #279

Closed rla2118 closed 7 years ago

rla2118 commented 7 years ago

This issue concerns

http://litpap.info/dclp/61352

The following principalEdition entry is not appearing in the HTML. The other bibl's with this subtype are, however.

<div type="bibliography" subtype="principalEdition">
            <listBibl>
               <bibl n="1" type="publication" subtype="principal">
            <!-- ignore - start, i.e. SoSOL users may not edit this -->
                  <title level="j" type="short-BP">ZPE</title>
                  <author n="1">
                     <surname>Gronewald</surname>
                     <forename>Michael</forename>
                  </author>
                  <date>1976</date>
                  <!-- ignore - stop -->
                  <ptr target="http://papyri.info/biblio/51367"/>
</bibl>
jcowey commented 7 years ago

This is category of bibliography for which, I think, we do not have the relevant XSLT. https://github.com/DCLP/idp.data/blob/master/DCLP/62/61352.xml#L168-L178 is the section we are dealing with. https://github.com/DCLP/idp.data/blob/master/DCLP/62/61352.xml#L177 guides to https://github.com/papyri/idp.data/blob/master/Biblio/52/51367.xml

what is expected is the content of the following tags: https://github.com/papyri/idp.data/blob/master/Biblio/1/511.xml#L4 https://github.com/papyri/idp.data/blob/master/Biblio/52/51367.xml#L19 https://github.com/papyri/idp.data/blob/master/Biblio/52/51367.xml#L8 - enclosed with brackets https://github.com/papyri/idp.data/blob/master/Biblio/52/51367.xml#L9

ZPE 22 (1976) 19-20

I would have thought that this was covered somewhere in https://github.com/papyri/navigator/blob/master/pn-xslt/htm-teibibl.xsl

wsalesky commented 7 years ago

@rla2118 @jcowey Okay, back and caffeinated.

The current rule for principalEdition in https://github.com/papyri/navigator/blob/master/pn-xslt/htm-teibibl.xsl first selects t:title[@type='short-Checklist'] and defaults tot:title if @type='short-Checklist' is not available. For all other bibl types, there is a more convoluted rule, that also pulls in t:relatedItem[@type='appearsIn']/t:title

All that is to say I can add the relatedItem handling to the principalEdition template. A few questions about the logic rules:

  1. Should the title found in the t:relatedItem[@type='appearsIn']/t:ptr take precedence over the t:title[@type='short-Checklist']?

Also, in this bibl record: https://github.com/papyri/idp.data/blob/master/Biblio/1/511.xml there are two titles:

  1. Does the t:title/@type="short-BP" take precedence over the t:title/@type="main"?
  2. Should t:title/@type="main" be used if there is no short title?
paregorios commented 7 years ago

@rla2118 and @jcowey please provide answers to @wsalesky's questions on this issue. We are blocked on completion until they are addressed. Thanks.

rla2118 commented 7 years ago

I'm ill versed in the jargon here. I defer to James.

wsalesky commented 7 years ago

@jcowey Thoughts on the questions below?

  1. Should the title found in the t:relatedItem[@type='appearsIn']/t:ptr take precedence over the t:title[@type='short-Checklist']?

Also, in this bibl record: https://github.com/papyri/idp.data/blob/master/Biblio/1/511.xml there are two titles:

  1. Does the t:title/@type="short-BP" take precedence over the t:title/@type="main"?
  2. Should t:title/@type="main" be used if there is no short title?
paregorios commented 7 years ago

@jcowey to respond

paregorios commented 7 years ago

This is a duplicate for #31. I'm consolidating this information into that ticket and will reiterate the question for @jcowey there.

paregorios commented 7 years ago

Transferred info to #31. Closing this ticket as duplicate.