search

DCLP / dclpxsltbox

Sandbox for development, testing, and review of XSLT for DCLP
http://dclp.github.io/dclpxsltbox/
1 stars 5 forks source link

illegal values in <objectDesc> "form" attribute cause errors in editor #311

Closed paregorios closed 6 years ago

paregorios commented 7 years ago

Some characters are prohibited from use in attribute values, but some illegal characters (e.g., "?") have been written into the "form" attribute on the <objectDesc> element in XML converted from LDAB (e.g., "roll?").

Files like this are invalid XML and shouldn't have been committed to the repository master branch without a successful attempt to validate them.

A user at the NYC workshop undertook to input a text for a DCLP stub file from LDAB that had this problem. He typed in the text and clicked "save." The editor reported an "XML Error" indicating an invalid value for the form attribute. Attempting to navigate back or to "save the broken Leiden plus" (which wasn't broken), resulted in everybody's favorite "we're sorry something went wrong" message.

paregorios commented 7 years ago

@jcowey @rla2118 please advise to whom this should be assigned for fixing

jcowey commented 7 years ago

yes this is bad news - shall have this chased up tomorrow

jcowey commented 7 years ago

which file was the one affected, so that it can be made available again?

paregorios commented 7 years ago

We fixed the file in question manually by editing the metadata and just removing the question mark. I will assemble a list of other offending files.

T

-- Tom Elliott, Ph.D. Associate Director for Digital Programs and Senior Research Scholar Institute for the Study of the Ancient World (NYU) http://isaw.nyu.edu/people/staff/tom-elliott

Humanities Commons: @paregorios https://hcommons.org/members/paregorios/ OrcID: 0000-0002-4114-6677 http://orcid.org/0000-0002-4114-6677

On Tue, Aug 8, 2017 at 3:29 PM, James M.S. Cowey notifications@github.com wrote:

which file was the one affected, so that it can be made available again?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DCLP/dclpxsltbox/issues/311#issuecomment-321057520, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQEdWcsQT3XF6fe5XgA48YIJjCkgbjsks5sWLcXgaJpZM4OxKix .

Edelweiss commented 7 years ago

Validator versions:

SoSOL http://www.stoa.org/epidoc/schema/8.22/tei-epidoc.rng

in eXist /db/data/epidoc/schema/latest/tei-epidoc.rng

some idp.data DCLP EpiDoc xml files have 8.13 (https://github.com/DCLP/idp.data/blame/master/DCLP/66/65429.xml)

Edelweiss commented 7 years ago

Found one example for form="roll?", valid for schema = 8.22 or latest

https://github.com/DCLP/idp.data/blob/master/DCLP/62/61362.xml#L34