ryanfb
commented
6 years ago Potentially related to #304, where the resolution was just to disable advanced create, which isn't a solution we can accept for merging to papyri.info.
Closed ryanfb closed 6 years ago
ryanfb
commented
6 years ago Potentially related to #304, where the resolution was just to disable advanced create, which isn't a solution we can accept for merging to papyri.info.
ryanfb
commented
6 years ago Following from discussion this morning, since DCLP meta and DLCP text use the same file, creating either for an existing publication means the publication should have both DCLP meta and text identifiers associated with the publication afterwards.
ryanfb
commented
6 years ago There's some partial work for this in this commit (adding a temporary_path method to DCLPTextIdentifier): https://github.com/ryanfb/sosol/commit/58403cc4b80cf8fbd45d61a8f283c23cab0ee912
But it doesn't fully resolve the errors.
jcowey
commented
6 years ago OK, thanks!
jcowey
commented
6 years ago At present Create New DCLP Publication works. One can create a new DCLP Publication and at least one real instance has been pushed right through the system with voting, finalizing etc.
This is the file in question:
If I "create new" DCLP text on an existing DDB publication, I get a "we're sorry" with the exception:
I also then get the same thing every time I click on the publication overview or the newly-created DCLP Text Identifier from the dashboard.
If I "create new" DCLP meta on an existing DDB publication, I get a "we're sorry" with the exception:
At https://github.com/dclp/sosol/blob/master/app/models/identifier.rb#L211 (this doesn't seem to be an actual Numbers Server timeout in this case, it's just getting
parts.nil?there every single time apparently). This is more severe as afterwards not only can I not load the publication overview or newly-created DCLP Meta Identifier, I can't even load the dashboard without throwing the error.If these are expected to be created (or not created) in a certain order, the UI/routes should enforce that.
Backtrace for DCLP text "undefined method temporary_path":
Backtrace for for DCLP meta "NumbersRDF::Timeout":