search

DCLP / dclpxsltbox

Sandbox for development, testing, and review of XSLT for DCLP
http://dclp.github.io/dclpxsltbox/
1 stars 5 forks source link

Add schema 8.23 to preprocess.xml #333

Closed Edelweiss closed 6 years ago

Edelweiss commented 6 years ago

DCLP Text identifiers should use the same preprocess.xml as DDB, or the transformation rules from DDB’s preprocess.xsl musst be copied over to whatever file DCLP Text is using.

preprocess.xsl XSLT for DDB, HGV and DCLPMeta

path to preprocess.xsl for DCLPText and DCLPMeta

Edelweiss commented 6 years ago

https://github.com/DCLP/sosol/commit/738085a0e6acf504cec65e9c2b8d7bf447144b5c

Edelweiss commented 6 years ago

@ryanfb, @paregorios, @jcowey, @m-k-r could you please review the changes made in the commit above as to whether they are necessary and valid. I think if they don’t break anything they should be comprised in the version for the new server.

ryanfb commented 6 years ago

The changes seem OK from the DDB side. I ran the resulting preprocess.xsl across DCLP/idp.data/DCLP with:

 find DCLP -type d | parallel --bar -j8 -u 'mkdir -p /Users/ryan/mess/current/dclp_preprocess/{}; java  -jar ~/source/dc3/dclp/sosol/lib/java/saxon9he.jar -xsl:/Users/ryan/source/dc3/dclp/sosol/data/xslt/ddb/preprocess.xsl -s:{} -o:/Users/ryan/mess/current/dclp_preprocess/{}'

The resulting diff is here: https://gist.github.com/ryanfb/c4bd5428ea858c23dfaf034fd4b08871

Most changes seem to be small whitespace modifications, moving/adding an empty <div type="edition"> so it comes right after <body>, stripping <!-- comments -->, and updating <langUsage>

paregorios commented 6 years ago

I don't see any problems from my end.