DCLP / dclpxsltbox

Sandbox for development, testing, and review of XSLT for DCLP
http://dclp.github.io/dclpxsltbox/
1 stars 5 forks source link

Use number server to lookup DCLP files #346

Open Edelweiss opened 6 years ago

Edelweiss commented 6 years ago

Make use of the number server when calling up dclp records

./app//controllers/publications_controller.rb:101:    if !(/papyri\.info\/dclp/ =~ identifier) # cromulent dclp hack to circumvent number server
./app//models/dclp_meta_identifier.rb:60:  # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:18:  # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:148:  # cl: CROMULENT DCLP ‘View in PN’ hack

Get Catalog Link

Edelweiss commented 6 years ago

https://github.com/DCLP/navigator/commit/2b4dca9298e893dced9179f75e281abc2f5e80c5

Edelweiss commented 6 years ago

see Hugh’s comment in #360

Edelweiss commented 6 years ago

blocks #334

Edelweiss commented 6 years ago

With the number server working for DCLP, ddb files and hgv files get picked up alonside translations when calling up a DCLP file in the editor (see pink box):

bildschirmfoto 2018-03-15 um 13 10 17

This behaviour needs to be changed so that only translations are picked up.

Edelweiss commented 6 years ago

Change url of numbers server and xpath https://github.com/DCLP/sosol/tree/issue360

use numbers server for DCLP https://github.com/DCLP/sosol/tree/issue346

Edelweiss commented 6 years ago

good test case TM no. 129793 (DCLP file that has relations to DDB, HGV and HGV_trans)

Edelweiss commented 6 years ago

When a translation is loaded alongside a DCLP record, the translation get the lead position (appearing in the title, being listed as the first item on the overview page, jumping automatically to the translations section after creation, see pink boxes)

bildschirmfoto 2018-03-15 um 14 04 56

Edelweiss commented 6 years ago

merged to development and master

https://github.com/DCLP/sosol/tree/development https://github.com/DCLP/sosol/tree/master

Can now be tested on DCLP test

Edelweiss commented 6 years ago

can also be tested on production