DCM-UPB / QNets

C++ library that allows to use (Feed Forward) Neural Networks in C++ with a few simple commands.
Other
2 stars 3 forks source link

GitHub CI / Review Apps #16

Closed Ithanil closed 6 years ago

Ithanil commented 6 years ago

I have settled for the following GitHub apps for the moment:

Mostly for TravisCI it was necessary to develop a configuration, which is .travis.yml

All services seem to work fine. However, in the code of current master and current open PRs there are a lot of issues found by codacy/codefactor. After we merged these PRs there will be an effort to improve on these at once.

Interesting NOTE: On the TravisCI MacOS platform our unittest 5 failed, because there was no "#include \<cmath>" in the main.cpp and for some reason this led to an ambiguity regarding abs(). But just on MacOS! Did you have this problem on your mac? Anyway, it was fixed by adding the include \<cmath>

EDIT: Sadly the TravisCI->Slack integration seems to be buggy when using encrypted secrets. And I won't add the unencrypted slack secret to a public repo, so I would say we leave the slack notification config like it is (and as it should be according to docs) and wait for a fix.