DCMLab / reductive_analysis_app

Web app for reductive analyses of scores
https://dcmlab.github.io/reductive_analysis_app/
Other
15 stars 4 forks source link

Prepend AGPL header to every relevant file when building with Vite (see comments for header text) #206

Closed yrammos closed 2 years ago

yrammos commented 2 years ago
=====
This file is part of MuseReduce, a webapp for graph-based musical analysis

Copyright (C) 2022  Petter Ericson, Yannis Rammos, Mehdi Mehra, and the EPFL Digital and Cognitive Musicology Lab (DCML).

MuseReduce is free software: you can redistribute it and/or modify it under the terms of the Affero General Public License as published by the Free Software Foundation. MuseReduce is distributed without explicit or implicit warranty. See the Affero General Public License at https://www.gnu.org/licenses/agpl-3.0.en.html for more details.
=====
yrammos commented 2 years ago

Relevant files:

(both pre- and post-build)

yrammos commented 2 years ago

Does Vite provide a plugin for this (analogously to those available for WebPack)?

meduzen commented 2 years ago

Should HTML files also receive the license header, like in #199?

Does Vite provide a plugin for this (analogously to those available for WebPack)?

As Vite is based on Rollup, maybe this plugin could fill the need. From what I read in this issue, it should work with Vite. Vite docs states that most Rollup plugins are usable in Vite out of the box.

Is there a reason why it would be needed through Vite on top of a GitHub action?

(Side note: I changed my name on the main branch, it was misspelled.)

yrammos commented 2 years ago

@meduzen thanks for these suggestions. The GitHub action was a potential kludge that I explored, then soon enough abandoned, in case Vite didn't provide the necessary facilities. I have since reverted these commits.