search

DCNick3 / ShinDataUtil

This is an utility for working with game files of Higurashi no Naku Koro ni and Kono Subarashii Sekai ni Shukufuku wo! Kibou no Meikyuu to Tsudoishi Boukenshata Plus (see branch konosuba) visual novels released for Nintendo Switch.
GNU General Public License v2.0
18 stars 4 forks source link

After last commit can't pack anything to new ROM #4

Closed masagrator closed 3 years ago

masagrator commented 3 years ago

Even if it's just one file in root. Windows and Ubuntu are showing the same error. Command:

dotnet shindatautil.dll rom-build ./patch.rom ./quiz.txa quiz.txa

Result

Process terminated. Assertion Failed
   at ShinDataUtil.Compression.ShinRomOperations.<BuildRom>g__AddEntry|1_0(IFileProvider source, String targetName, <>c__DisplayClass1_0& ) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Compression\ShinRomOperations.cs:line 73
   at ShinDataUtil.Compression.ShinRomOperations.BuildRom(Stream outrom, IEnumerable`1 files) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Compression\ShinRomOperations.cs:line 122
   at ShinDataUtil.Compression.ShinRomOperations.BuildRom(Stream outrom, IEnumerable`1 files) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Compression\ShinRomOperations.cs:line 230
   at ShinDataUtil.Program.RomBuild(ReadOnlySpan`1 args) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Program.cs:line 439
   at ShinDataUtil.Program.ActionList.Execute(String actionname, ReadOnlySpan`1 args) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Program.cs:line 511
   at ShinDataUtil.Program.MainWrap(String[] args) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Program.cs:line 542
   at ShinDataUtil.Program.Main(String[] args) in C:\Users\Admin\Documents\Switch\Higurashi\ShinDataUtil2\ShinDataUtil\Program.cs:line 549

Build with Visual Studio 2019 on Windows, dotnet 5.0.

Beside it's possible to write new function for packing that will just recursively scan folder we provide as argument and pack all of files inside? This way we can avoid Windows cmd limit that is 2048 characters per command (and will make life easier when putting new files regularly)

masagrator commented 3 years ago

Nvm. My fault. It's lacking / on target name

DCNick3 commented 3 years ago

Will probably change the error message to something more meaningful

DCNick3 commented 3 years ago

Done in a664457688d22dc2fe1bc5374353afc335050a34