search

DCNick3 / shin

A reimplementation of VN engine primarily used by 07-th expansion releases on consoles (and some other entergram games)
https://dcnick3.github.io/shin/shin/
Mozilla Public License 2.0
29 stars 2 forks source link

Restructure the rendering pipeline to do the blending the "wrong way" #6

Open DCNick3 opened 1 year ago

DCNick3 commented 1 year ago

So, apparently, entergram has fucked up gamma correctness in their engine...

image

They do not mark textures as being in sRGB space (but they are!) and therefore all computations happen without conversion to linear space (but they should be converted!)

Because of this I couldn't get the messagebox opacity to look quite right (to be the same as in the game)....

Alpha blending (RES = a src + (1-a) dst) was done in the different colorspace, so the result is different

To implement the same in our engine we would need to use texture views with differing srgb-ness, tracked at gfx-rs/wgpu#3237

DCNick3 commented 1 year ago

Don't forget to remove extra renderpass from the movielayer