Refactor search menu field combobox

DCS-LCSR / SignStream3

Sign language linguistics annotation software

2 stars 0 forks source link

Refactor search menu field combobox #556

Open gregorydimitriadis opened 1 year ago

gregorydimitriadis commented 1 year ago

There was an edit in the search code working around the graph fields. Two ideas for refactoring - likely should do both:

make a method in the coding schema class to get fields minus the graph fields
in the search rule, instead of the comboboxes containing strings, instead make new objects for the comboboxes to contain - the object would have an {id}=>{name} reference, so either can be obtained from the 'selected' item/index of the combobox

douglas-motto-at-rutgers commented 1 year ago

The code that applies to the "Search" feature in SignStream, hard codes the identity of graph fields, as apposed to GLOSS or non-manual fields. This "hard coding" identification may cause problems now or long term. This issue suggest that the identification mechanism of fields be improved and would require a code refactor.