search

DCS-LCSR / SignStream3

Sign language linguistics annotation software
2 stars 0 forks source link

Minor issue: Local sign bank treats GLOSS and GLOSS+ as distinct #626

Open cneidle opened 1 year ago

cneidle commented 1 year ago

Within the Sign Bank, plus signs are not included in any glosses for the listings of main entries and entry/variants.

SO these two glosses should both be entered under WEEKLY.

Screen Shot 2023-01-24 at 6 05 19 PM
gregorydimitriadis commented 1 year ago

@cneidle is WEEKLY in the current/latest global sign bank file? I couldn't see it there.

Also, can you clarify what should happen in this scenario? Are both WEEKLY and WEEKLY+ individual entries in the sign bank file? And if they are, is the intended behavior to ignore the "+" sign ones?

cneidle commented 1 year ago

No.

It’s not in the Global Sign Bank.

The Global Sign Bank never includes any GLOSS+

This arose when I was adding new signs via the local Sign Bank. That is the only way to add signs to the sign bank in SignStream.

If the user chooses to add to the (local) Sign Bank a sign like WEEKLY+, it should be entered as WEEKLY.

If WEEKLY already exists, it should not be added again.

So, yes the intended behavior is to ignore the + signs in the Sign Bank. Example: BUY++ is grouped with BUY within the Sign Bank:

On Jan 25, 2023, at 12:10 PM, Greg Dimitriadis @.***> wrote:

@cneidle https://github.com/cneidle is WEEKLY in the current/latest global sign bank file? I couldn't see it there.

Also, can you clarify what should happen in this scenario? Are both WEEKLY and WEEKLY+ individual entries in the sign bank file? And if they are, is the intended behavior to ignore the "+" sign ones?

— Reply to this email directly, view it on GitHub https://github.com/DCS-LCSR/SignStream3/issues/626#issuecomment-1403952630, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH7NQUPQKUIXBN7N7YZH5DWUFNBPANCNFSM6AAAAAAUFVIIRA. You are receiving this because you were mentioned.