Morph-Phon Open /w Gloss Unselected

[douglas-motto-at-rutgers]

1. Selecting a gloss and opening the morph-phon window for it should lock the selection of that gloss in utterance window.

Currently create gloss. Select it (it is red). Open morph-phon for it. You should not be able to select another gloss. Nor deselect the current gloss. Until the morph-phon window is closed.

[douglas-motto-at-rutgers]

2. Created two 2-handed glosses "LEFT" and "RIGHT". Was able to select dom gloss line of "RIGHT" . Saw "RIGHT" in red. Opened morph-phon window for it. now clicked on dom hand line of "LEFT"...Saw "LEFT" in red....while the morphon-phon window for RIGHT is still open. changed name of entry from RIGHT to NEWRIGHT. clicked "bypass sign bank check".

the RIGHT gloss changed its name to NEWRIGHT.

but the morphon window was still open (or i reopened)....and now it doesn't display its handshapes that it previously had (perhaps a different issue).

[douglas-motto-at-rutgers]

3. another example of weirdness.

create gloss...select gloss (see it in red) open morphon

You can add new glosses in the utterance window while the morph-phone window is open.

When the current gloss becomes unselected...and then clicked "bypass"...weird things happen.

[douglas-motto-at-rutgers]

another example of weirdness.

create gloss...select gloss (see it in red)...open morphon

You can also select other non-manual fields...and the original gloss becomes unselected

again....clicking bypass it doesn't display its handshapes that it previously had (perhaps a different issue).

When the current gloss becomes unselected...and then clicked "bypass"...weird things happen.

[douglas-motto-at-rutgers]

checking to see if this happens in the latest pre-release version

[douglas-motto-at-rutgers]

yes in latest...and possibly earlier.

Looks like anytime the morph-phon is open...and the gloss gets deselected...bad things happen.

[douglas-motto-at-rutgers]

confirmed in 3.4.0

[gregorydimitriadis]

@douglas-motto-at-rutgers I cannot reproduce. Can you list exact steps which were taken? I cannot even click a different gloss while the MorphPhon window is open. I do not know where the underscores before LEFT and RIGHT, in your example, are referring to.

I can reproduce creating a new gloss while MorphPhon is open, but haven't seen any detrimental effects from it.

Testing on prerelease version "2023_02_24_0928"

@cneidle thoughts? Can you reproduce?

[cneidle]

A) I cannot reproduce the issues I have labeled as (1) and (2) above. I am able to create a new gloss (3 above) while the morph-phon window is open, which should obviously not be allowed. I am also able to select non-manual events (4 above), which also should not happen. When I select a non-manual event with the Morph-Phon window open, handshapes having been selected, sometimes (but not consistently) the handshapes disappear from that window.

B) As I was trying the things above, Sign Bank check often was not working. I was able to use the Enter button for things that do not exist in the Sign Bank.

C) When I created a new gloss, selected it, and tried to use the left and right arrows to advance the video, they did not work.

I imagine that (B) and (C) are their own issues, but I don't know if these problems are related to the things I was trying with the Morph-Phon window.

[cneidle]

What SHOULD happen is that when the Morph-phon window is open, the selected gloss should not be able to be deselected (which means that nothing else should be able to be selected). It should be possible to use the navigation buttons, e.g., to play the selected gloss, to go to the beginning and end of that gloss, etc., but the gloss should remain selected. Thanks.

[douglas-motto-at-rutgers]

Per (B)...see https://github.com/DCS-LCSR/SignStream3/issues/523

[gregorydimitriadis]

@cneidle Doug showed me the issue. Here is how to reproduce:

• make the example as he had, with 2 two-handed glosses annotated
• click to open the MP window for the first gloss, then select the "dom hshape" or "ndom hshape" line for the second gloss
• then attempt to enter/bypass out of the MP window - this is an error here
• if you keep hitting bypass, I can see the handshapes disappear from the first gloss.

So - first, can you reproduce that as well? And secondly, priority to fix in this release or no?

[douglas-motto-at-rutgers]

Also as Carol stated in "A" above. If the MP window is open for any gloss and a non-manual hand is selected, keep hitting bypass in the MP will result in the handshapes disappearing from the gloss.

[cneidle]

Yes, I can reproduce the disappearance of handshapes by following those instructions.

It would be a fairly high priority to lock the gloss selection when the Morph-phon window has been opened, disallowing selecting anything else until the Morph-phon window has been closed. do you have a sense of how big a job this would be? Thanks.

[gregorydimitriadis]

@cneidle I will check it out this afternoon. If simple I'll fix it outright.

[gregorydimitriadis]

Was able to implement a fix to allow glosses to not be de-selected during MorphPhon editing, and other events to not be selected during this time. Marking as code complete for now.

[cneidle]

Terrific. Thanks very much.

[gregorydimitriadis]

Released in 3.4.1