search

DCS-LCSR / SignStream3

Sign language linguistics annotation software
2 stars 0 forks source link

Overzealous enforcement of "no spaces" in text of gloss #677

Open cneidle opened 1 year ago

cneidle commented 1 year ago

Spaces must be allowed within quotation marks -- i.e., for gestures and classifiers.

Screen Shot 2023-04-12 at 2 47 18 PM Screen Shot 2023-04-12 at 2 46 53 PM
cneidle commented 1 year ago

I was able to get around this by inserting a non-breaking space, but I don't know if that is going to cause a problem later on, for Augustine's parser...

copying Augustine @kwasiopoku

gregorydimitriadis commented 1 year ago

This wound up being a relatively quick fix.

cneidle commented 1 year ago

Excellent!

thanks

Carol

On Apr 26, 2023, at 4:39 PM, Greg Dimitriadis @.***> wrote:

This wound up being a relatively quick fix.

— Reply to this email directly, view it on GitHub https://github.com/DCS-LCSR/SignStream3/issues/677#issuecomment-1524017006, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH7NQWDQ4TE5EL3PMSRR73XDGBZNANCNFSM6AAAAAAW4CELXY. You are receiving this because you authored the thread.

cneidle commented 9 months ago

Listed as "code complete" as of May 23, but it is still a problem...

cneidle commented 9 months ago

Note that non-breaking spaces no longer work. FWIW.

gregorydimitriadis commented 9 months ago

Main issue remaining here: allowing spaces between quotes, and not elsewhere.

gregorydimitriadis commented 9 months ago

Carol, how should this apply when creating new glosses? When we create the text values (before providing a start/end time) would this same logic of allowing spaces only between quotes apply there as well? As in, spaces not between quotes would still separate into different 'words' but spaces inside quotes would be considered part of the same 'word'

cneidle commented 9 months ago

Yes. That sounds right. Thanks!

On Oct 5, 2023, at 3:07 PM, Greg Dimitriadis @.***> wrote:

Carol, how should this apply when creating new glosses? When we create the text values (before providing a start/end time) would this same logic of allowing spaces only between quotes apply there as well? As in, spaces not between quotes would still separate into different 'words' but spaces inside quotes would be considered part of the same 'word'

— Reply to this email directly, view it on GitHub https://github.com/DCS-LCSR/SignStream3/issues/677#issuecomment-1749489935, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH7NQSBE5OOPVBMDOZ2FA3X54AQPAVCNFSM6AAAAAAW4CELX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGQ4DSOJTGU. You are receiving this because you authored the thread.

gregorydimitriadis commented 8 months ago

@cneidle Does this apply to allowing spaces within double quotes, or within single quotes as well?

cneidle commented 8 months ago

Best to also allow spaces within single quotes as well. Thanks!Sent from my iPhone; please excuse typos.On Oct 9, 2023, at 9:44 AM, Greg Dimitriadis @.***> wrote: @cneidle Does this apply to allowing spaces within double quotes, or within single quotes as well?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

gregorydimitriadis commented 7 months ago

@cneidle are single quotes ever used in the names of glosses and/or gestures? I'm wondering if we can just disallow single quotes from being entered here, which may make some things simpler on the backend. Or if that would be too heavy-handed, and we would rather allow single quotes.

cneidle commented 7 months ago

Hi Greg,

I don’t believe we need to allow single quotes in the same context where we need to allow double quotes.

However, we do need to allow ‘ in a gloss, between double quotes, e.g., (1h)5"that's the way it is” or (1h)5"what's going on?"

Thanks, Carol

On Nov 20, 2023, at 2:04 PM, Greg Dimitriadis @.***> wrote:

@cneidle https://github.com/cneidle are single quotes ever used in the names of glosses and/or gestures? I'm wondering if we can just disallow single quotes from being entered here, which may make some things simpler on the backend. Or if that would be too heavy-handed, and we would rather allow single quotes.

— Reply to this email directly, view it on GitHub https://github.com/DCS-LCSR/SignStream3/issues/677#issuecomment-1819640994, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH7NQQU7XQWR5I235PISI3YFOSUHAVCNFSM6AAAAAAW4CELX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGY2DAOJZGQ. You are receiving this because you were mentioned.

cneidle commented 7 months ago

This seems to work, in allowing, e.g., 5"test this item". We discussed single quotes, and I thought you decided not to allow that. But it is allowed, in fact -- which is not a problem !

So I think we can close this issue :-). Thank you.

gregorydimitriadis commented 7 months ago

Yes, single quotes are allowed within double quotes, like the examples here. It also works in reverse, so:

word'words inside"single quote'

would also be valid (despite not making logical sense).

cneidle commented 7 months ago

Close this issue now? Thanks very much.

cneidle commented 3 months ago

There are still problems

Screen Shot 2024-03-14 at 3 40 10 PM
cneidle commented 3 months ago

Furthermore:

Screen Shot 2024-03-14 at 3 43 36 PM
cneidle commented 3 months ago

The above two reports involve v. 3.4.1. OS 11.7.10

cneidle commented 1 week ago

This mostly seems to have been fixed in 3.4.1. The only time this error shows up is when editing a pre-existing gloss that contains quotation marks. This can be resolved by retyping the quotation marks. (I assume there is some issue with legacy special characters used for " .) If this remains as it is, we should probably include a warning in the documentation for the next release.