DCS-LCSR / SignStream3

Sign language linguistics annotation software
2 stars 0 forks source link

Handshape palette overhaul/refactor #696

Open gregorydimitriadis opened 9 months ago

gregorydimitriadis commented 9 months ago

Handshape palette overhaul/refactor - making look and feel consistent across glosses and gestures, resolving bugs and inconsistencies, increasing code quality and long-term maintenance capability

Spun off from https://github.com/DCS-LCSR/SignStream3/issues/693

cneidle commented 7 months ago

SERIOUS PROBLEM - Select handshapes has no effect.

I click on the button, but nothing happens.

Screen Shot 2023-11-30 at 11 45 12 AM

There is another problem, as well. This sign is showing up as a gesture! It should be fingerspelled.

I am not able to reproduce the appearance of such signs as gestures. I closed the file and reopened, and THAT did not happen again. However, I am systematically unable to open the handshape selector.

cneidle commented 7 months ago

Welllll, the Select Handshapes button is working for me now - for signs that are not fingerspelled, at least. and for signs that I newly create and classify as fingerspelled. So that problem seems to be mainly or only with signs previously annotated as fingerspelled.

However, if I create a new sign and select its type as NUMBER, then I am also not able to open the handshape selector.

Screen Shot 2023-11-30 at 12 18 41 PM

Same for Loan sign. And I am also finding this now for newly created signs designated as fingerspelled.

cneidle commented 7 months ago

"Do not include" should not be an option for ASL glosses (i.e., only for gestures):

Screen Shot 2023-11-30 at 12 12 04 PM
cneidle commented 7 months ago

"Clear" does not fully clear the entry of letters ...

Screen Shot 2023-11-30 at 12 13 47 PM
cneidle commented 7 months ago

What is this? If it is not available, it should not be visible...

Screen Shot 2023-11-30 at 12 16 28 PM
cneidle commented 7 months ago

The handshape palette also does not appear if there is a sign previously annotated as a number sign or a loan sign.

Screen Shot 2023-11-30 at 12 31 17 PM Screen Shot 2023-11-30 at 12 31 48 PM