Update state_class for import / export entities

DCSBL / ha-homewizard-energy

The old custom Home Assistant integration for HomeWizard Energy. This integration is now available in Core.

https://community.home-assistant.io/t/custom-component-homewizard-energy-wifi-p1-meter-and-kwh-meter/227441

Apache License 2.0

26 stars 3 forks source link

Update state_class for import / export entities #52

Closed klaasnicolaas closed 3 years ago

klaasnicolaas commented 3 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) The adjustments in this pull request ensure that the state_class is correct and the entities work properly again in the energy dashboard.
What is the current behavior? (You can also link to an open issue here) Users get an error message in the energy dashboard
What is the new behavior (if this is a feature change)? The import and export entities have the correct state_class again
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Nope
Other information:

DCSBL commented 3 years ago

Thank you for your time! This change is already added in https://github.com/DCSBL/ha-homewizard-energy/pull/51 and rolled out in 0.10.0.

klaasnicolaas commented 3 years ago

Strange, I overlooked that change because the PR title was about gas. But glad it's resolved 😄

DCSBL commented 3 years ago

Yeah that is something that was not quite clear. I've updated the release notes. Anyway, thanks for the heads-up!

klaasnicolaas commented 3 years ago

A little tip, keep pull requests small and to the point as the title stands for. Is easier with reviews and changes are findable for those who want to contribute. (We also use this in the core repository of Home Assistant) 😉 But otherwise great work and keep it up!

klaasnicolaas commented 3 years ago

@DCSBL I think you had another question here, something about bringing integration to core. If you need help you can always contact me on Discord (Mister Nicolaz#7558) 😉