search

DCsunset / pandoc-include

A pandoc filter to allow file and header inclusion
MIT License
63 stars 14 forks source link

fix: should unescape underscores back from markdown strict #47

Closed belonesox closed 4 months ago

belonesox commented 4 months ago

Lets consider include line 

!include somefolder/filename_with_underscores.md

We got following json para.json para-json.zip

when we call inner_convert_text we run pandoc like that

    pandoc --from=json --to=markdown_strict ./para.json

For me pandoc 3.1.12.3 returns 

!include somefolder/filename\_with\_underscores.md

So we have to unescape underscores back, or we will got [WARNING] Included file not found: later.

DCsunset commented 4 months ago

Thanks. LGTM!

One minor thing: could you reword your commit using the format fix: ...? In this way, I can generate the change log automatically.

belonesox commented 4 months ago

could you reword your commit using the format fix: ...?

I tried, looks I reword also another commit. :(

DCsunset commented 4 months ago

Your changes are gone now. I'm not sure what you did. But you could have done it with git commit --amend. Could you clean up your branch and add your changes back?

belonesox commented 4 months ago

Sorry, something wrong with my git-fu, just push next pull here https://github.com/DCsunset/pandoc-include/pull/48

Hope, next pull be more interesting, I am testing synctex-like support (with pandoc-include) of syncing markdown source with preview.

DCsunset commented 4 months ago

Thanks. Merged #48 already.