search

DCsunset / vscode-modal-editor

Customizable extension to turn VS Code into a modal editor
GNU Affero General Public License v3.0
36 stars 4 forks source link

Add `R` binds to `helix.js` #16

Closed SimonRask closed 3 months ago

DCsunset commented 3 months ago

Hi, thanks for you contribution. However, I don't think it's necessary to add another option as you can run modalEditor.delete first and then modalEditor.paste

SimonRask commented 3 months ago

Yeah, that might be better. I don't have much experience with the vscode API, but my thought was that it would potentially be better to have a single call to TextEditor.edit(). I would be glad to add the replace functionality for the helix keymap according your suggestion. Whatever you prefer :)

DCsunset commented 3 months ago

It might be slightly better in performance to have one call, but unless it's a significant improvement (with evidence provided), I think the complexity outweighs the benefit. I think you can go ahead with the delete command.

SimonRask commented 3 months ago

This should work :)

DCsunset commented 3 months ago

Merged into main branch with squashing