Closed anthonyjclark closed 2 years ago
Also, sorry that I did not turn-off my auto-formatter. I can try to remove those line edits if you'd like.
Thanks for your contribution! I think it's fine to format the code. It just takes some time to distinguish the changes. I'll try to finish reviewing soon.
@anthonyjclark Do you have any update on this?
As long as your OK with the edits from the auto-formatter, I think it is ready for you to review. I might have misunderstood your first reply though. Let me know if there are any changes you'd like me to make.
Oh sorry it seems that the review was not published correctly. Now I've submitted the code review.
I agree with you on using matchAll
. The newest commit does so, and it works in my limited testing.
It looks good to me. Thanks for your contribution!
Hello,
I added regex support to
findText
. I found this useful for (for example):editor.emmet.action.decrementNumberByOne
Feel free to ignore, change, or move the code into a new function as you want.