danielt3
commented
4 years ago Sorry, but I do not wish to add a kludge fix like this. Compiler errors and warnings are beyond annoying, but they exist for a reason. I really appreciate the effort, but let's look at long term real fixes and do it right.
OK. The two main goals were:
- to, at least, get a working version with a newer compiler (which seems better than using an old one);
- fix the build break so people don't have to bother installing a different compiler from the default one in their Linux boxes.
If this was accepted the idea was to immediately start working in more robust fixes and I totally agree with you these are kludge. In my opinion, however, they present low risk of breaking anything and we have all the newer warning and checks from newer compilers avaliable to assess the rest of the code and this is why I thought these fixes were worth.
It will take some time for me to get used with the code and fix these bugs properly but I will give it a try.
Thank you for letting me be part of the team.
Pull Request
General Description
This pull request fixes gcc-9 (and potentially newer) build breaks by disabling specific checks in specific lines of the code. Real fixes would demand more experience with the code, which is something I don't have ATM. But it is great to be able to build with newer GCC versions on fresh installs.
Fixes #200.