DCurrent / openbor

OpenBOR is the ultimate 2D side scrolling engine for beat em' ups, shooters, and more!

http://www.chronocrash.com

BSD 3-Clause "New" or "Revised" License

901 stars 121 forks source link

Taco dog #233

Closed TacoDog311 closed 3 years ago

TacoDog311 commented 3 years ago

Pull Request

General Description

Makefile fixes for GCC 9 compilations Vita compilation fixes Added a new cheat for instant kills

Darknior commented 3 years ago

Excellent, i love the new cheat for instant kills :) It will help to save time when trying games for fix, thanks

DCurrent commented 3 years ago

Not sure I'm ok with this. Your pull request is really messy... nearly 40 commits that are already in the source code. Also from what I can tell, the Gcc9 fix is just suppressing errors rather than fixing the cause. I'll need to review this a bit more.

TacoDog311 commented 3 years ago

Not sure I'm ok with this. Your pull request is really messy... nearly 40 commits that are already in the source code. Also from what I can tell, the Gcc9 fix is just suppressing errors rather than fixing the cause. I'll need to review this a bit more.

I agree actually with the mess, the compiler fixes are admittedly hacky. But which commits are already in the source?

Perhaps I should separate out the new cheat, which I think is cleaner and useful for debugging.

DCurrent commented 3 years ago

That's probably for the best. If you submit a commit that just has the cheat, I should be able to include it,