Sound & Playgif Glitch

[DCurrent]

Description

Starting at commit 83525e80 in dc_unified_updates branch, engine appears to have severe issues simultaneously streaming data. This manifests most obviously as opening music stopping or playing as "radio static" when an animated .gif such as an intro sequences or logo starts to play.

Debugging

Reproduce

1. Download original BOR to ensure no scripts or other advanced techniques are to blame.
2. Open with last known good commit, d10bdc32. The module will load and play normally.
3. Open and test with 83525e80. The opening music is garbage static or will not play at all. Logo cinematic utilizing animated .gif files will include artifacts and doubling (See screenshots). I have not tested with WebM video but presumably it will have similar issues.

Expected behavior

Engine should have ability to stream music and .gif files simultaneously.

Screenshots

Version

Note versions are found in dc_unified_updates branch:

• d10bdc32 - Last known good.
• 83525e80 - Bug appears.

There are several versions in between that do not compile due to being in progress work. They invoke minimal changes, all related to permissions in packfile.c. I have tested with changes removed and bug persisted.

[fgames9000]

I sent a code for you in the forum

[DCurrent]

You are a lifesaver @fgames9000. I knew it was something super simple, but spent hours beating my head against the wall trying to find it. Thanks again!

[Plombo]

Something tangentially related I discovered looking at the commit 83525e8 you mentioned is that you forgot to change "per" to "file_permission" on line 466, and Linux compilation is broken on your branch as a result.

[fgames9000]

Yeah, Plombo is right. Sorry man, I didn't test Linux build

[DCurrent]

@Plombo & @fgames9000, thanks for the catch. I'll get that fixed.