Closed resadent closed 8 months ago
This is going to break compilation on systems without glibc >= 2.33. It doesn't look like there's a simple feature macro to check whether mallinfo2 is supported, so we should probably #include <features.h>
and wrap the mallinfo2 call around an #if __GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 33)
to remain compatible with everything.
Sorry it took me so long to see this. I defer to @Plombo. Appreciate the contribution, but I can't approve a change that breaks that much across the board.
Thank you for the comments and the review. I will have a look to @Plombo's comments to see if I can fix compilation on older builds 😀 .
Just fixed this https://github.com/DCurrent/openbor/pull/287 so we can close this down.
Mallinfo is deprecated. Changed all the occurrences with mallinfo2. Now builds in newer systems. Fixes #243.