Build script fixes - Githubissues

j8r commented 2 years ago

I'm working on packaging OpenBOR to flatpak - of course if you agree (the planned name is com.ChronoCrash.OpenBOR).

However, I came across minor issues related to the build script:

The script is always returning a exit code of 1 due a condition, see the first commit for more details. Here are examples to better understand how the UNIX shell work:
```
true || printf b && printf c && printf d  #=> cd
false || printf b && printf c && printf d #=> bcd
```
The shebang was not taken into account because it must be at the first line. This means on Debian, dash - the default shell - will run the script, which won't work.
Minor change, use the recommended parentheses notation for command substitution ($()), which is supported now since at least 20 years by alll systems and shells. backticks can be considered are deprecated.

msmalik681 commented 8 months ago

@DCurrent if its OK with you I have no concerns on these changes they seem to tidy up the Linux compiling nicely.

DCurrent commented 8 months ago

I don't see any problems off hand. Pulling it in. Thanks @j8r.

DCurrent / openbor