I'm working on packaging OpenBOR to flatpak - of course if you agree (the planned name is com.ChronoCrash.OpenBOR).
However, I came across minor issues related to the build script:
The script is always returning a exit code of 1 due a condition, see the first commit for more details.
Here are examples to better understand how the UNIX shell work:
true || printf b && printf c && printf d #=> cd
false || printf b && printf c && printf d #=> bcd
The shebang was not taken into account because it must be at the first line. This means on Debian, dash - the default shell - will run the script, which won't work.
Minor change, use the recommended parentheses notation for command substitution ($()), which is supported now since at least 20 years by alll systems and shells. backticks can be considered are deprecated.
I'm working on packaging OpenBOR to flatpak - of course if you agree (the planned name is
com.ChronoCrash.OpenBOR
).However, I came across minor issues related to the build script:
dash
- the default shell - will run the script, which won't work.$()
), which is supported now since at least 20 years by alll systems and shells. backticks can be considered are deprecated.