DCurrent / openbor

OpenBOR is the ultimate 2D side scrolling engine for beat em' ups, shooters, and more!
http://www.chronocrash.com
BSD 3-Clause "New" or "Revised" License
894 stars 119 forks source link

Change config files to .ini instead of binary .cfg file #298

Closed Tartifless closed 5 months ago

Tartifless commented 5 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I am always frustrated to see the .cfg file in binary format, would be so much easier to work with a readable .ini file. Also to provide help or support.

Describe the solution you'd like A clear and concise description of what you want to happen.

Having a .ini file instead if a binary .cfg file.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Darknior commented 5 months ago

For sure it is the best way. And there is zero interest to make it not readable ... CFG file dont permit to cheat in games or nothing else ... it is only here to choose some minor options like SCREEN RATIO, or SHADER, etc ...

To enable cheat in games the player must unpack the PAK file ... but for sure, for me this option too should be in the INI file and the user should choose to cheat the game or not. I can understand the game author is not agree, but it is a player decision ;) And when we are playing with young children it halp a lot, i always add it to all my games ... nut it is not the subject lol

We already do what you want in Batocera from a long time ... we patch the EXE file before compiling it to make a real INI file and let the user configure options in the launcher. for sure it's cool too, to let a user choosing his launcher :) All our patch are here ...

https://github.com/batocera-linux/batocera.linux/blob/985a9b95b7028886b7be5fb7b264fe5291481eac/package/batocera/emulators/openbor/openbor6412/005-axismanagement.patch

I wish some will be added one day ...

The other patch is for us, for our auto gamepad configuration but it is not used out of Batocera.

dbaldan commented 5 months ago

@Darknior "I can understand the game author is not agree, but it is a player decision ;) '" I strongly disagree. It's a dev decision, not a player decision. If the dev doesn't want his game to be used with cheats and the player doesn't agree with it, just pick another game to play :)

I really wish we got rid of those infinity health/lives/etc cheats someday.

The good thing is: activating V4 "touch of death" cheat in any game using scripted slams will screw up the enemies. And that is not a bug: that cheat was supposed to be used by the devs when they develop the game, not bu players.

Tartifless commented 5 months ago

Why has this deviated in cheats discussion, original request had nothing to do with cheats.

dbaldan commented 5 months ago

Why has this deviated in cheats discussion, original request had nothing to do with cheats.

You are right on this one. But there is a ticket that looks like this one already.

DCurrent commented 5 months ago

Duplicate issue. Closing.

Tartifless commented 5 months ago

Can you point me to the other issue ? I have checked all opened issue but did not find in the list

DCurrent commented 5 months ago

It was also closed because of the nature of the request. Config ini for certain options like controllers is already in the works. However, in general, most options will remain in binary config. OpenBOR is not an emulator. It is a game engine, and how those games work is up to the creator.

Tartifless commented 5 months ago

Thanks, good to hear, only interested in fullscreen, aspect ratio and controllers anyway (maybe filters), if these are considered, it would be great.

dbaldan commented 5 months ago

Thanks, good to hear, only interested in fullscreen, aspect ratio and controllers anyway (maybe filters), if these are considered, it would be great.

All those things can be already modified in the game options. No need to add it to an external file .

As Damon said, Open Bor is not an emulator

Tartifless commented 5 months ago

Controllers is difficult to modify in game options when only a controller is connected. But that is being worked on, so that's great, fullscreen also might be handy for the same purpose.

Of course it is not an emulator, and nobody wants it to be, but it runs games through a dedicated executable, so it is also a launcher.

Anyway no need to argue further and glad that this is in the works.

dbaldan commented 5 months ago

Controllers were fixed in V4 version, you have no problem mapping then anymore.

And no, it's not a launcher either - a launcher executes a second executable. Here you execute the engine itself :)

Tartifless commented 5 months ago

Please stop this unnecessary discussion. It's being worked on so it's all fine.

My sentence meant that it is necessary to run openbor.exe, on the opposite of self-contained game executables.

And v4 works fine but when you have no keyboard or mouse, it's impossible to configure a controller, this is why a .ini for controllers is very nice to have. And knowing we'll have it one day is great !