search

DD-DeCaF / iloop-to-model

Power model service with ILoop data
Apache License 2.0
0 stars 0 forks source link

Unconventional message format #48

Closed matyasfodor closed 6 years ago

matyasfodor commented 6 years ago

The response from this endpoint resembles the one we receive from model service, but it is a bit different: growthRate should be growth-rate (the best would be to update it in model service, use camelCase if possible) added and removed reactions are missing although they are included in the messages.

Is it possible to add them?

matyasfodor commented 6 years ago

@sgalkina I assigned to you because I remember you were working on this service. Feel free to pass it over if you don't have time.

siddC commented 6 years ago

Hi Matyas, just a bit curious, but why should growthRate be growth-rate? Is it necessary for the service? Or just for consistency in naming convention?

matyasfodor commented 6 years ago

@siddC We use it as growth-rate in the model service: https://github.com/DD-DeCaF/model/blob/3767fbbc65208019cae1c5645f1b7c28ad9e9e57/model/constants.py#L66 and this causes duplication in the frontend: https://github.com/DD-DeCaF/metabolica-ui-map/blob/master/src/pathwayvis/components/map/map.component.ts#L311-L336

matyasfodor commented 6 years ago

I'd rather go with growthRate in both services, for all message keys, but I dont' know how much work that'd be

kvikshaug commented 6 years ago

This likely won't be fixed in this project so I'm closing the issue, but I've added a card to come to a decision on casing, set it in the guidelines and then try to follow it consistently in all relevant services.